-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and linting changes #264
Update dependencies and linting changes #264
Conversation
7e5c722
to
4af6e47
Compare
All looks good to me except I would not upgrade Kotlin version unless it's strictly necessary
I also had some doubts regarding usage of |
Thanks Anton for the review. What is latest version of Kotlin which is not experimental or just reverting back to 1.6 makes more sense? |
I would leave 1.6 unless there is a need for upgrade |
Cool. Makes sense. I changed it to the latest version of 1.6. Had to downgrade couple of libraries to previous versions. |
@@ -40,7 +40,7 @@ dependencies { | |||
api("io.netty:netty-all:4.1.87.Final") | |||
api("com.google.protobuf:protobuf-java:3.21.12") | |||
|
|||
implementation(kotlin("stdlib")) | |||
implementation(kotlin("stdlib-jdk8")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe no need to revert this lib back to stdlib-jdk8
as we switched to Java-11 target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I read from Kotlin 1.8 stdlib-jdk8 is merged into kotlin-stdlib . Otherwise, it is preferred to use stdlib-jdk8
to make use of the jdk8 extensions.
Yep, that's the downside of not upgrade. Seems like no critical libs has to be downgraded though |
fcf0a47
to
92c5652
Compare
Just force pushed a cleaner commit without a lot of linting changes (which applies only to the later versions of Kotlin and the kotlinter) |
kotlin
version from 1.6.10 to 1.6.21me.champeau.jmh
gradle pluginlintKotlin
taskjvmTarget
,sourceCompatibility
andtargetCompatibility
to Java 11 (align with the README.md saying Java 11 is needed.)build.gradle
nits suggested by IntelliJfixes #242