Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve muxer test coverage. Fix several muxer issues #285

Merged
merged 9 commits into from
May 30, 2023
Merged

Improve muxer test coverage. Fix several muxer issues #285

merged 9 commits into from
May 30, 2023

Conversation

Nashatyrev
Copy link
Collaborator

@Nashatyrev Nashatyrev commented May 25, 2023 •
edited
Loading

  • More muxer tests
    • Refactor MuxHandlerAbstractTest: add ability to handle outbound messages
    • Control and check ByteBuf allocations and releases
    • Add more testcases and assertions
  • Fix found issues:
    • [Generic] (buffer leak) release message buffer if inbound frame have non-existing streamId: 71c68c4
    • [Yamux] Process RST (Reset) flag: 42e40f6
    • [Generic] Writing to a stream which was prior closed should be prohibited: d3c4580
    • [Generic] Receiving a data on a steam which was remotely closed should result in exception (recoverable, i.e. connection should not be terminated): 8974317
    • [Yamux] switch the logic of onLocalDisconnect() and onLocalClose() methods. onLocalDisconnect() should leave the stream open for inbound data: 820c252
    • [Yamux] need to clean up stream entries on any kind of stream closure (local Reset, remote Reset, local + remote Close): 66ef36b
  • Convert RemoteWriteClosed to singleton

Part of #272
Follow up to #281
Fix #27

Nashatyrev added 9 commits May 25, 2023 08:52
@Nashatyrev
Fix ByteBuf leak in muxers when a mux frame is received for non-exist…
71c68c4 
…ing stream id. Add buffer ref count check to MuxHandler tests
@Nashatyrev
Convert RemoteWriteClosed to singleton
1455b11
@Nashatyrev
YamuxHandler: process RST (Reset) flag
42e40f6
@Nashatyrev
MplexHandler: writing to a stream which was closed for writing should…
d3c4580 
… result in exception
@Nashatyrev
MplexHandler: reading from a stream which was closed remotely for wri…
8974317 
…ting should result in exception
@Nashatyrev
YamuxHandler: switch the logic of onLocalDisconnect() and onLocalClos…
820c252 
…e() methods. onLocalDisconnect() should leave the stream open for inbound data
@Nashatyrev
Add more test cases and checks to the MuxHandlerAbstractTest
d4ebf28
@Nashatyrev
* AbstractMuxHandler: add onChildClosed() event
66ef36b 
* Cleanup YamuxHandler per-stream data on onChildClosed()
* YamuxHandler: move per-stream data init to a separate onStreamCreate() method
@Nashatyrev
Formatting
87feb06
@Nashatyrev Nashatyrev marked this pull request as ready for review May 25, 2023 05:10
@Nashatyrev Nashatyrev mentioned this pull request May 25, 2023
Open
ianopolous
ianopolous approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@ianopolous ianopolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Looks good to me.

tbenr
tbenr approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashatyrev Nashatyrev mentioned this pull request May 30, 2023
Open
@Nashatyrev Nashatyrev merged commit 0981ec6 into libp2p:v1.0.0 May 30, 2023
@Nashatyrev Nashatyrev mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

@ianopolous ianopolous ianopolous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nashatyrev @ianopolous @tbenr