Fix yamux remote open #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #291 |
Nashatyrev
requested changes
Jun 8, 2023
Comment on lines
78
to
79
| onStreamCreate(msg.id) // sometimes writes can happen before onRemoteCreated is called | ||
| onRemoteOpen(msg.id) |
There was a problem hiding this comment.
That would result to onStreamCreate() is called twice.
What's the intention of calling onStreamCreate() explicitly here?
There was a problem hiding this comment.
The send window needs to be initialized before onRemoteOpen, otherwise it errors and fails to do the first write.
|
I was hoping you could help with the unit test, as my Kotlin is not up to scratch (You probably guessed but this is the first Kotlin I've written). |
|
@ianopolous please check Peergos#10 |
Nashatyrev
approved these changes
Jun 9, 2023
Add unit test
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitswap and identify from kubo, on a connection we initiated, was failing because we were not writing the /multistream/1.0.0 because the send window had not been initialised yet for a remote opened stream in yamux.
We should also tolerate window updates which close a stream and have 0 size (rather than error).
Would also make an excellent candidate unit test.
A connects to B
B opens stream to A
A immediately writes /multistream/1.0.0\n (This must happen during onRemoteOpen)
B does a single write of /multistream/1.0.0\n/ipfs/id/1.0.0\n
A writes /ipfs/id/1.0.0\n
B must receive both writes for success