[Yamux] Send whole data if window size is > 0 #319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some inconsistencies with
sendFrames
method and the send bufferflush
approach to sending data.sendFrames
was checking if window size is <= 0 and adding to buffer if so and afterwards was slicing the data based on the window size and sending across. So essentially if window size is 10 and data is 100 bytes, it will send across 10 frames of 10 bytes.flush
was respecting the window size and was sending partial data if the length of the data is less than the window size.I would imagine a better approach is if window size is > 0, just send the whole data respecting the
maxFrameDataLength
.flush
not usesendFrames
since the data is already limited bymaxFrameDataLength
so no slicing neededsendFrames
tosendData
sendData
to respect the window size and add to buffer there instead ofonChildWrite
onChildWrite
and no window size is found.