Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MuxId #322

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Refactor MuxId #322

merged 8 commits into from
Sep 14, 2023

Conversation

Nashatyrev
Copy link
Collaborator

@Nashatyrev Nashatyrev commented Sep 14, 2023 •
edited
Loading

There is some inconsistency with MuxId for Yamux: the StreamId for yamux is just a Long while stream id for Mplex is a pair of (Long, Boolean). So we need to abstract MuxId and make it consistent across both muxers

We also need to validate remote StreamId on remote stream opening (SYN for Yamux)

@Nashatyrev
Copy link
Collaborator Author

Relates to #312 (comment) and PR #318

@Nashatyrev Nashatyrev marked this pull request as ready for review September 14, 2023 12:42
StefanBratanov
StefanBratanov approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashatyrev Nashatyrev merged commit e3aeca3 into libp2p:develop Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashatyrev @StefanBratanov