Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/makesomenoise #37

Merged
merged 204 commits into from
Nov 13, 2019
Merged

Feature/makesomenoise #37

merged 204 commits into from
Nov 13, 2019

Conversation

shahankhatch
Copy link
Contributor

PR for #35

Nashatyrev and others added 30 commits July 5, 2019 14:36
@Nashatyrev
Update NetworkTest to pass mplex negotiation
1956dc5
@Nashatyrev
Very initial draft of MultistreamHandler
6086ea8
@Nashatyrev
Refactor MultistreamChannel/Handler: extract abstract classes
fe63764
@Nashatyrev
Merge remote-tracking branch 'origin/master' into feature/multistream…
3cfaef0 
…-handler
@Nashatyrev
Create child channel on eventLoop for thread-safety
d6e0403
@Nashatyrev
Correctly process any type of channel close, add support for multiple…
215a5f8 
…x close/reset. Close == disconnect(), Reset == close()
@snazha-blkio
Merge branch 'sketch' of https://github.com/libp2p/jvm-libp2p into fe…
80a720c 
…ature/mplex

# Conflicts:
#	src/test/kotlin/io/libp2p/core/security/secio/NetworkTest.kt
@snazha-blkio
WIP - Skeleton for stream mplex implementation
d07398c
@Nashatyrev
Fix multistream Negotiator to correctly handle varint prefixes. Add '…
0aacfde 
…ls' support

Resolve #28
@Nashatyrev
Change the test to cover Negotiator and ProtocolSelect handlers
0f60f73 
Resolve #29
@Nashatyrev
Fix lint warning
d23ff03
@snazha-blkio
WIP - varint support for ByteArray.
e021410
@snazha-blkio
Merge branch 'master' of https://github.com/libp2p/jvm-libp2p into fe…
fed44c8 
…ature/mplex
@snazha-blkio
WIP - stream state management
775551f
@snazha-blkio
Merge branch 'feature/multistream-handler' of https://github.com/libp…
5c3d06d 
…2p/jvm-libp2p into feature/mplex
@Nashatyrev
Merge pull request #30 from libp2p/fix/multistream-varint
c822376 
Address a couple of issues
@snazha-blkio
WIP - Linting
4c43350
@snazha-blkio
Merge branch 'feature/multistream-handler' of https://github.com/libp…
2d5339f 
…2p/jvm-libp2p into feature/mplex
@Nashatyrev
Add a bit more logic to TcpTransport
d3d1ee4
@Nashatyrev
Remove debug out
aa772cf
@Nashatyrev
Add test logging for mplex frames
6aae8e7
@Nashatyrev
Add Multistream wrapper class
cf30874
@Nashatyrev
Refactor Transport API: dial/listen now requires sync callback which …
e75f83d 
…should init channel
@Nashatyrev
Fix lint errors
d29b148
@Nashatyrev
Switch to openjdk8 since oraclejdk8 is no more available on Travis
86baa1a
@Nashatyrev
Merge pull request #26 from libp2p/feature/mplex
f2b8454 
WIP: mplex implementation.
Resolve #16
@Nashatyrev
Merge branch 'feature/multistream-handler' of https://github.com/libp…
e39332c 
…2p/jvm-libp2p into feature/multistream-handler
@Nashatyrev
Refactor mplex codec
58a17f6
@Nashatyrev
Merge branch 'feature/framework-adjust' into feature/multistream-handler
65d98a5
@Nashatyrev
Working EchoSampleTest
b764c5c
@Nashatyrev Nashatyrev mentioned this pull request Oct 2, 2019
Merged
Nashatyrev
Nashatyrev reviewed Oct 2, 2019
View reviewed changes
Copy link
Collaborator

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed all my comments in a separate PR: #48

src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
shahankhatch and others added 15 commits October 2, 2019 16:14
@shahankhatch
Attempting to use NoiseXXSecureChannel in HostTest
3137f40
@jezhiggins
Refactored tests
3bbe71a
@jezhiggins
s/msg1.array/msg1.toByteArray/
99ea4cb 
Calling ByteBuff::array() directly causes an exception.
@jezhiggins
Lint fixes
8b9959d
@jezhiggins
Made HostTest abstract so JUnit doesn't try to run it
8ee63d5
@jezhiggins
add tags
324fbca
@jezhiggins
Change when handlers are removed - the setup is sensitive to this. No…
d7bb124 
…ise negotiation now proceeds further
@jezhiggins
Add NoiseXXCodec after signalling session - Boom, now it works.
5f928c9
@jezhiggins
Lint fixes
cee5b19
@shahankhatch
Payload is identity public key and signed noise static key
dce8204 
Noise static key initialized per process. Also, Noise static key (signed by identity private key) is verified as early as possible. Added new protobuf struct to hold identity pub key and signed noise static key, as well as data and signed data. Currently data fields are not examined or kept.
@shahankhatch
Added string prefix to signed data and verification
63362dd
@shahankhatch
Fixes to Noise channel and also enables multiple parallel connections
f7e16a8
@shahankhatch
Making Noise protocol implementation more robust to timeouts and errors.
66f1b5d
@shahankhatch
Fix for recognizing successful connections
666f1e3
@Nashatyrev
Fix lint warns
f31f47f
Nashatyrev
Nashatyrev reviewed Oct 16, 2019
View reviewed changes
Copy link
Collaborator

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase PR to the develop branch?

src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
src/main/kotlin/io/libp2p/security/noise/NoiseXXSecureChannel.kt Outdated Show resolved Hide resolved
@shahankhatch
Updates for PR comments on logging and message buffer sizes
a8830c9
@shahankhatch
linted
f9d094e
@shahankhatch
Merge remote-tracking branch 'remotes/origin/develop' into feature/ma…
5017a28 
…kesomenoise

# Conflicts:
#	build.gradle.kts
#	src/main/kotlin/io/libp2p/core/multiformats/Protocol.kt
#	src/main/kotlin/io/libp2p/host/HostImpl.kt
#	src/main/kotlin/io/libp2p/host/MemoryAddressBook.kt
#	src/main/kotlin/io/libp2p/network/NetworkImpl.kt
#	src/main/kotlin/io/libp2p/transport/tcp/TcpTransport.kt
#	src/test/java/io/libp2p/tools/p2pd/P2PDDht.java
#	src/test/java/io/libp2p/tools/p2pd/P2PDHost.java
#	src/test/java/io/libp2p/tools/p2pd/libp2pj/DHT.java
#	src/test/java/io/libp2p/tools/p2pd/libp2pj/Host.java
#	src/test/java/io/libp2p/tools/p2pd/libp2pj/PeerInfo.java
#	src/test/java/io/libp2p/tools/p2pd/libp2pj/Transport.java
#	src/test/kotlin/io/libp2p/core/HostTest.kt
#	src/test/kotlin/io/libp2p/core/RpcHandlerTest.kt
#	src/test/kotlin/io/libp2p/pubsub/GoInteropTest.kt
#	src/test/kotlin/io/libp2p/pubsub/PubsubRouterTest.kt
#	src/test/kotlin/io/libp2p/security/secio/EchoSampleTest.kt
#	src/test/kotlin/io/libp2p/security/secio/SecIoSecureChannelTest.kt
#	src/test/kotlin/io/libp2p/security/secio/SecioHandshakeTest.kt
#	src/test/kotlin/io/libp2p/transport/tcp/TcpTransportTest.kt
@shahankhatch shahankhatch changed the base branch from feature/cleanup to develop October 22, 2019 04:14
@Nashatyrev
Copy link
Collaborator

@shahankhatch thanks for addressing my comments 👍
I'd also made some minor code cleanups

@Nashatyrev Nashatyrev merged commit 94d1d4b into develop Nov 13, 2019
@Nashatyrev Nashatyrev deleted the feature/makesomenoise branch November 15, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashatyrev Nashatyrev Nashatyrev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahankhatch @Nashatyrev @snazha-blkio @jezhiggins