Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract libp2p-identity crate #3349

Closed
Tracked by #3271
thomaseizinger opened this issue Jan 19, 2023 · 2 comments · Fixed by #3350
Closed
Tracked by #3271

Extract libp2p-identity crate #3349

thomaseizinger opened this issue Jan 19, 2023 · 2 comments · Fixed by #3350

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Jan 19, 2023

This issue is part of #3271.

@thomaseizinger
Copy link
Contributor Author

  • We can consider moving PeerRecord and SignedEnvelope into this crate as well or extract them into their own. I am undecided here.

Already running into the first issue as I am starting to work on this.

A PeerRecord depends on Multiaddr as well as PeerId. If we want multiaddr to depend on libp2p-identity, we can't define PeerRecord within libp2p-identity otherwise we have a circular dependency!

@thomaseizinger
Copy link
Contributor Author

  • We can consider moving PeerRecord and SignedEnvelope into this crate as well or extract them into their own. I am undecided here.

Already running into the first issue as I am starting to work on this.

A PeerRecord depends on Multiaddr as well as PeerId. If we want multiaddr to depend on libp2p-identity, we can't define PeerRecord within libp2p-identity otherwise we have a circular dependency!

The solution to this turned out to be to not use the proto definition of PeerId in PeerRecord but treat it as opaque bytes instead that we parse through the functions available in libp2p-identity::PeerId.

mxinden pushed a commit that referenced this issue Mar 12, 2023
This patch combines the `libp2p_core::identity` and `libp2p_core::peer_id` modules into a new crate: `libp2p-identity`.

Resolves #3349.

Pull-Request: #3350.
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this issue Mar 8, 2024
This patch combines the `libp2p_core::identity` and `libp2p_core::peer_id` modules into a new crate: `libp2p-identity`.

Resolves libp2p#3349.

Pull-Request: libp2p#3350.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant