New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: always run `cargo` with `--locked` #3547

Closed

mxinden opened this issue Mar 3, 2023 · 3 comments · Fixed by #3587

Member

mxinden commented Mar 3, 2023

Summary

Since #3399 we are tracking the Cargo.lock file via version control. Currently CI does not fail when the checked in Cargo.lock is not up-to-date.

Possible Solution

Replace all cargo XXX with cargo --locked XXX.

Can you think of a simpler solution @thomaseizinger?

Would you like to work on fixing this bug?

Yes

The text was updated successfully, but these errors were encountered:

Contributor

thomaseizinger commented Mar 3, 2023

Good idea!

Maybe there is an env variable we can set?

mxinden added a commit to mxinden/rust-libp2p that referenced this issue


          feat: Use cargo --locked whenever possible

11c1c15

> Since libp2p#3399 we are tracking the `Cargo.lock` file via
version control. Currently CI does not fail when the checked in `Cargo.lock` is not up-to-date.

libp2p#3547

mxinden mentioned this issue

feat: Use cargo --locked whenever possible #3562

Closed

Member Author

mxinden commented Mar 7, 2023

#3562 does the change as a flag. I could not figure out how to do the same with an environment variable. @thomaseizinger let me know if this works for you.

thomaseizinger mentioned this issue

feat(ci): add dedicated job for ensuring the lockfile is up-to-date #3587

Merged

4 tasks

Member Author

mxinden commented Mar 10, 2023

Closing here in favor of #3587

mxinden closed this as completed

mergify bot pushed a commit that referenced this issue


          feat(ci): add dedicated job for ensuring the lockfile is up-to-date

dea6a8c

Instead of running with `--locked` which would require us to pick a CI job that does this, we can add a dedicated job that only has as its responsibility to ensure that `Cargo.lock` is up-to-date.

Fixes #3547.

Pull-Request: #3587.

thomaseizinger mentioned this issue

feat: introduce libp2p-allow-block-list connection management module #3590

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment