remove rustc-serialize #359
Labels
Comments
|
Note: https://github.com/RustCrypto has pretty much all of the things from rust-crypto ported and updated |
gnunicorn
pushed a commit
that referenced
this issue
Aug 10, 2018
* Replace rust-crypto dependency by RustCrypto project crate aes-ctr * Support for x86 build supporting both aesni and aessoft at runtime. Feature gated behind 'aes-all'. Building requires RUSTFLAGS="-C target-feature=+aes,+ssse3" and RUSTDOCFLAGS="-C target-feature=+aes,+ssse3". Only support x86 case. * Change CI to build with aes ni on all-features * Switch aes-all logic (is_x86 runtime test did not work as I thought when RUSTC aes and sse are enabled). To build with aes-all, aes and sse flag should not be set. * Use latest aesni from crates.io (with pr to disable compile time checks). * Replace rust-crypto dependency by RustCrypto project crate aes-ctr * Support for x86 build supporting both aesni and aessoft at runtime. Feature gated behind 'aes-all'. Building requires RUSTFLAGS="-C target-feature=+aes,+ssse3" and RUSTDOCFLAGS="-C target-feature=+aes,+ssse3". Only support x86 case. * Change CI to build with aes ni on all-features * Switch aes-all logic (is_x86 runtime test did not work as I thought when RUSTC aes and sse are enabled). To build with aes-all, aes and sse flag should not be set. * Use latest aesni from crates.io (with pr to disable compile time checks).
tomaka
added a commit
to tomaka/libp2p-rs
that referenced
this issue
Sep 7, 2018
This reverts commit 7399688.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As the investigation of #358 showed, we still rely on the (long time) deprecated
rustc-serialize-crate, primarily through the (also abandoned?) rust-crypto dependency.There seem to be only a few reasonable to deal with this: replace rust-crypto alltogether, switch it over to a wasm-compatible fork like the one from buttercup or fork the project and maintain our own fork (as removing rustc-serialize doesn't seem to be too hard).
The text was updated successfully, but these errors were encountered: