-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace custom-clippy
alias with workspace-wide [lints]
configuration
#4484
Labels
Comments
can i take this one @thomaseizinger |
4 tasks
Yes! Thank you :) |
monoid
pushed a commit
to fluencelabs/rust-libp2p
that referenced
this issue
Oct 9, 2023
Starting with nightly-2023-09-10, the `[lints]` section in `Cargo.toml` files is stable. Together with workspace inheritance, this can be used to declare all lints we want to enforce in a single place. Resolves: libp2p#4484. Pull-Request: libp2p#4575.
umgefahren
pushed a commit
to umgefahren/rust-libp2p
that referenced
this issue
Mar 8, 2024
Starting with nightly-2023-09-10, the `[lints]` section in `Cargo.toml` files is stable. Together with workspace inheritance, this can be used to declare all lints we want to enforce in a single place. Resolves: libp2p#4484. Pull-Request: libp2p#4575.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we have an alias for standardizing our lint configuration:
rust-libp2p/.cargo/config.toml
Line 3 in 240019f
There is a new cargo feature on the way that allows to configure lints in the
Cargo.toml
. Together with workspace-inheritance, we should be able to move our lint configuration away from the alias to a configuration that is only specified once in our rootCargo.toml
.Here is the tracking issue: rust-lang/cargo#12115
This should stable from
nightly-2023-09-10
onwards. We should be able to start experimenting with this by adding the relevant nightly toolchain here:rust-libp2p/.github/workflows/ci.yml
Lines 202 to 205 in 240019f
custom-clippy
over toCargo.toml
.Contributions welcome!
The text was updated successfully, but these errors were encountered: