Address some reviewing #1246
Merged
Address some reviewing #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Sep 18, 2019
| // TODO: we use `Pin<Box<Pending>>` instead of just `Pending` because `Pending` doesn't | ||
| // implement `Unpin` even though it should ; this is just a dummy template parameter and | ||
| // the `Box` is never actually created, so this has no repercusion whatsoever | ||
| // see https://github.com/rust-lang-nursery/futures-rs/pull/1746 | ||
| let task: Task<Pin<Box<futures::future::Pending<_>>>, _, _, _, _, _, _> = |
There was a problem hiding this comment.
Wouldn't this also work now?
Suggested change
| let task: Task<Pin<Box<futures::future::Pending<_>>>, _, _, _, _, _, _> = | |
| let task: Task<futures::future::Pending<_>, _, _, _, _, _, _> = |
There was a problem hiding this comment.
Yes, but also why change it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some reviewing in #1196