*: Remove usage of custom buffer initialization usage #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With version `0.3.0-alpha.19` the futures-preview crate makes the `AsyncRead::initializer` API unstable. In order to improve interoperability with e.g. both a library depending on alpha.18 as well as a library depending on alpha.19 and in order for rust-libp2p to become stable again, this commit removes all usages of the unstable `initializer` API.
|
Is this ready? Shall we merge this? Or is there any blocker? |
|
Not yet ready for a proper review. I will update this pull request and ping you again. |
mxinden
commented
Oct 31, 2019
| @@ -80,10 +80,6 @@ where | |||
| fn destroy_outbound(&self, _: Self::OutboundSubstream) { | |||
| } | |||
|
|
|||
| unsafe fn prepare_uninitialized_buffer(&self, _: &mut [u8]) -> bool { | |||
There was a problem hiding this comment.
Should this pull request touch this as well?
With version 0.3.0-alpha.19 the futures-preview crate makes the AsyncRead::initializer API unstable. Given that the previous commits removed usage of the initializer API, the version pinning is not needed any longer.
twittner
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With version
0.3.0-alpha.19the futures-preview crate makes theAsyncRead::initializerAPI unstable.In order to improve interoperability with e.g. both a library depending
on alpha.18 as well as a library depending on alpha.19 and in order for
rust-libp2p to become stable again, this commit removes all usages of
the unstable
initializerAPI.Status
As of today async-std is pinned to futures-preview0.3.0-alpha.18. Given that rust libp2p depends on async-std, we don't have much of a choice anyways but to stick withalpha.18for now.