Upgrade websocket transport to soketto 0.3.0. #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently pointing to twittner's repo until the corresponding PR is merged. Also forces futures-preview to alpha.18 dues to breaking changes w.r.t. AsyncRead's initializer API.
tomaka
reviewed
Oct 1, 2019
transports/websocket/src/framed.rs
Outdated
| async fn dial_once | ||
| ( self | ||
| , address: Multiaddr | ||
| ) -> Result<Either<String, BytesConnection<T::Output>>, Error<T::Error>> |
There was a problem hiding this comment.
That code style looks like abstract art.
tomaka
reviewed
Oct 1, 2019
tomaka
approved these changes
Oct 2, 2019
|
(let's merge paritytech/soketto#3 first and update the Cargo.toml) |
mxinden
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pointing to twittner's repo until the corresponding PR is merged. Also forces futures-preview to alpha.18 dues to breaking changes w.r.t. AsyncRead's initializer API.