Update yamux to development version. #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the boxed `futures::stream::Stream` we have to decide if we require a `Send` bound or not. Since some upgrades may produce outputs which are `!Send` we offer both upgrade versions.
tomaka
approved these changes
Nov 7, 2019
mxinden
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the Yamux development version which is based on futures-preview 0.3.0-alpha.19. Since we use a boxed version of the incoming
futures::stream::Streamof substreams, we offer two sets of upgrades, one which requires aSendbound on the underlying I/O resource, and one which does not. If memory serves me well, we have some upgrades such as secio whose output is!Send. If we do not plan to support!Send, we can of course remove half of this PR.