Add PartialOrd and Ord for PeerId #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for using PeerId in order based collections. Ord uses borrow to be consistent with equality.
tomaka
approved these changes
Jun 2, 2020
|
You seem to have unchecked the "Allow maintainers to modify my branch" checkbox, so please merge master so we can merge this. |
|
Sorry, was on holiday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for using PeerId in order based collections, and for other niceties like deterministic debug output when e.g. printing a set of peer ids.
Ord uses borrow to be consistent with equality.