Gossipsub: Use sets instead of vectors inside behaviour state #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
commented
Jul 23, 2020
| @@ -771,7 +766,9 @@ impl Gossipsub { | |||
| } | |||
| } | |||
| } | |||
| peers.retain(|peer| to_remove_peers.contains(&peer)); | |||
There was a problem hiding this comment.
This is different than in the old code, but I think the old code has the condition flipped.
rklaehn
changed the title
|
This a nice addition. There are some extra checks (for duplicates in the Vectors) that we no longer need and can be removed. I'm going to try and finish up fixing all these bugs and hopefully address your issue in #1583. To this end, I've merged these into there. |
AgeManning
added a commit
to sigp/rust-libp2p
that referenced
this pull request
Jul 24, 2020
|
So the signing PR is basically your development branch? I might have a few DRY refactoring improvements that I will PR against that one then. Anyway, I am going to close this PR. Thanks for the inclusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To completely eliminate the possibility of having duplicate peers in these sets