Fix connection keep-alive for request-response. #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
reviewed
Aug 13, 2020
| @@ -313,7 +313,7 @@ where | |||
| self.outbound.shrink_to_fit(); | |||
| } | |||
|
|
|||
| if self.inbound.is_empty() { | |||
| if self.inbound.is_empty() && self.keep_alive.is_yes() { | |||
There was a problem hiding this comment.
Paraphrasing this to make sure I am on the same page: Without the additional && self.keep_alive.is_yes() this condition would be triggered on each poll if the inbound queue is empty and thus the self.keep_alive timeout would be refreshed each time leaving it no time to expire. Is that correct?
mxinden
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon reviewing #1698 I double-checked the analogous handling in
request-responsewhich seemed to lack a condition, resulting in an indefinite keep-alive. More generally and judging from prior experience from other handlers where the keep-alive handling has been tricky to get right, it seems this keep-alive handling may better be done in a more general manner inlibp2p-core, for all connection handlers. Not sure yet how realistic that is though.