-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pure-rust protoc #255
Use pure-rust protoc #255
Conversation
Shouldn't we generate the Rust files in the directory pointed by the |
Unfortunately (like #259), this is also failing on Windows for me. I can confirm that the diff locally between this PR and master is the same. Here is the cargo build output. |
This is ring failing and has nothing to do with I mentioned this on Riot but for posterity: rust-lang/rfcs#752 blocks us from doing this properly. There's a plugin implementing a workaround but A) it requires nightly and B) it requires an old nightly (it doesn't work anymore) |
I suggest to not close #183 (or reopen it after merging) so that we fix that correctly eventually. |
This reverts commit 217fae4.
Closes #183
This was basically a couple hours of
grep
+sed
pipelines and runningcargo test
until it compiled