Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sr25519 keys #2671

Closed
wants to merge 4 commits into from
Closed

Add sr25519 keys #2671

wants to merge 4 commits into from

Conversation

i1i1
Copy link

@i1i1 i1i1 commented May 23, 2022 •
edited
Loading

Description

This pr is followup of spec issue. It adds support for sr25519 keys for libp2p.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

nazar-pc
nazar-pc reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, though consensus needs to be reached on whether to include this in the first place.

core/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor

I am converting this to a draft until this lands in the specs repo.

@thomaseizinger thomaseizinger marked this pull request as draft November 2, 2022 03:47
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2023

This pull request has merge conflicts. Could you please resolve them @i1i1? 🙏

@i1i1 i1i1 closed this Mar 23, 2023
@i1i1 i1i1 deleted the add-sr25519-keys branch March 23, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazar-pc nazar-pc nazar-pc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i1i1 @thomaseizinger @nazar-pc