core/muxing: Drop Sync requirement for StreamMuxer on StreamMuxerBox
#2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rBox` `StreamMuxerBox` is never shared across threads but owned by a single connection. Restricting it to be `Sync` unnecessarily limits the design space around the `StreamMuxer` trait and its implementations.
This was referenced Jul 25, 2022
thomaseizinger
commented
Jul 25, 2022
elenaf9
approved these changes
Jul 25, 2022
core/src/transport/upgrade.rs
Outdated
Comment on lines
301
to
304
| T::Error: Send + Sync, | ||
| M: StreamMuxer + Send + Sync + 'static, | ||
| M: StreamMuxer + Send + 'static, | ||
| M::Substream: Send + Unpin + 'static, | ||
| M::Error: Send + Sync + 'static, |
There was a problem hiding this comment.
Could we also drop the other Sync requirements here?
There was a problem hiding this comment.
Maybe. I'd say we do it in a different PR though :)
mxinden
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StreamMuxerBoxis never shared across threads but owned by a singleconnection. Restricting it to be
Syncunnecessarily limits the designspace around the
StreamMuxertrait and its implementations.Links to any relevant issues
Required for #2765.
Open Questions
Change checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have added tests that prove my fix is effective or that my feature works