Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/coding-guidelines: Document limit on number of tasks #2839

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Aug 24, 2022

Description

Add guideline to limit number of tasks being spawned.

I think we discussed adding this to the guidelines somewhere, but I forgot where. Anyways, what do folks think?

Links to any relevant issues

Coding guidelines introduced through #2780.

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Add guideline to limit number of tasks being spawned.
docs/coding-guidelines.md Outdated Show resolved Hide resolved
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
@mxinden mxinden marked this pull request as ready for review August 26, 2022 05:07
@mxinden mxinden merged commit a3dec47 into libp2p:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants