Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Update clap to v4 #3015

Merged
merged 3 commits into from
Oct 14, 2022
Merged

build(deps): Update clap to v4 #3015

merged 3 commits into from
Oct 14, 2022

Conversation

koushiro
Copy link
Contributor

Signed-off-by: koushiro koushiro.cqx@gmail.com

Description

Update clap to v4

Links to any relevant issues

Close #3008

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@koushiro
Update clap to v4
0d41244 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
thomaseizinger
thomaseizinger reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There seem to be several CI failures, can you look into those please?

@koushiro
Copy link
Contributor Author

@thomaseizinger Fixed

jxs
jxs approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@thomaseizinger thomaseizinger changed the title Update clap to v4 build(deps): Update clap to v4 Oct 14, 2022
@thomaseizinger thomaseizinger merged commit d9a2e6c into libp2p:master Oct 14, 2022
@koushiro koushiro deleted the update-clap-v4 branch October 14, 2022 06:09
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
@koushiro
build(deps): Update clap to v4 (libp2p#3015)
738e3a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger left review comments

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koushiro @jxs @thomaseizinger