*: Fix newly raised clippy warnings #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Hi Hannes LGTM! Curious, how did you run cargo clippy, did you run the custom-clippy?
core/CHANGELOG.md
Outdated
| @@ -4,8 +4,11 @@ | |||
|
|
|||
| - Hide `prost::Error` from public API in `FromEnvelopeError::InvalidPeerRecord` and `signed_envelope::DecodingError`. See [PR 3058]. | |||
|
|
|||
| - Fixed minor clippy issue. See [PR 3106]. | |||
There was a problem hiding this comment.
I don't think we need to announce clippy improvements in the CHANGELOG.md if they don't affect the public API, see here
There was a problem hiding this comment.
Agreed, lets not clutter the changelog with such details.
There was a problem hiding this comment.
I removed the changes from the changelog.
|
Related: #3090 |
thomaseizinger
requested changes
Nov 10, 2022
thomaseizinger
approved these changes
Nov 11, 2022
thomaseizinger
changed the title
7 tasks
|
@Mergifyio backport rust-v0480-testplan |
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
Fixed minor issues raised by clippy to improve correctness and readablitity. (cherry picked from commit c32f03c) # Conflicts: # examples/gossipsub-chat.rs # protocols/kad/src/query/peers/closest/disjoint.rs
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I corrected warnings raised by clippy that accumulated or came from a new iteration of clippy.
Change checklist
Commit message body
Fixed minor issues raised by clippy to improve correctness and readablitity.