feat(swarm): deprecate SwarmBuilder in favor of configuring Swarm
#3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in #3186 (comment) I would prefer making |
We are on the same page but this PR is older than your comment :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We expose various fields on
Poolaspub(crate)so we can modify them after aPoolhas been constructed. This allows us to deprecateSwarmBuilderand add configuration options toSwarmdirectly.Resolves #3186.
Notes
Depends-On: #3188
Links to any relevant issues
Open Questions
Change checklist
I have added tests that prove my fix is effective or that my feature works