fix(examples/file-sharing): set Kademlia Mode::Server

[mxinden]

Description

Explicitly set libp2p-kad Kademlia::set_mode to Mode::Server to reduce complexity of example, i.e. not having to explicitly set external addresses.

Notes & open questions

Similar to #4194.

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[thomaseizinger]

Explicitly set libp2p-kad Kademlia::set_mode to Mode::Server to reduce complexity of example, i.e. not having to explicitly set external addresses.

Is that a good thing? Would it be better if we teach users to "correctly" configure their Swarm with an external address?

[mxinden]

In my eyes, explicitly setting Mode::Server reduces complexity. This example showcases how to use libp2p in a larger application architecture. I don't think users should worry about Kademlia details like requiring an external address. In addition, I expect users to run this locally. Setting a localhost address as an external address would be confusing to me.

Does the above change your position here @thomaseizinger?

[thomaseizinger]

In my eyes, explicitly setting Mode::Server reduces complexity. This example showcases how to use libp2p in a larger application architecture. I don't think users should worry about Kademlia details like requiring an external address. In addition, I expect users to run this locally. Setting a localhost address as an external address would be confusing to me.

Does the above change your position here @thomaseizinger?

Sounds good to me!

[mxinden]

Mind approving @thomaseizinger?

[mxinden]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed