Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(examples): add rendezvous point fixed keypair #4646

Closed

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Oct 13, 2023

Description

Related: #4380.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (No changes needed)
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@bgins
Copy link
Contributor Author

bgins commented Oct 13, 2023

I was a bit terse about the checklist because it ends up the commit. Let me know docs, changelog entries, or tests should be added.

@thomaseizinger
Copy link
Contributor

I was a bit terse about the checklist because it ends up the commit. Let me know docs, changelog entries, or tests should be added.

I've updated the description for you, thanks! :)

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up again!

One suggestion, otherwise good to merge :)

PS: Are you interested in adding https://github.com/ipvm-wg/homestar to https://github.com/libp2p/rust-libp2p?tab=readme-ov-file#notable-users?

examples/rendezvous/src/main.rs Show resolved Hide resolved
@bgins
Copy link
Contributor Author

bgins commented Oct 16, 2023

@bgins
Copy link
Contributor Author

bgins commented Oct 17, 2023

Closed in favor of #4681

@bgins bgins closed this Oct 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

⚠️ The sha of the head commit of this PR conflicts with #4681. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants