Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow opt-out of changelog lint for internal changes #4673

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

We introduced a lint in #4620 that ensures the changelog is updated when we touch a certain crate. This however leads to many "false-positives" where a change to the source code is not actually worth mentioning in the changelog.

To opt out of this change, this patch adds a condition to the job that checks for a internal:$crate label and if that is applied, it doesn't run the lint.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger
Copy link
Contributor Author

Opening this as a an idea how we could resolve the changelog lint problem. It will result in a fair few labels over time but I think by namespacing them, they should all be easier to find still.

@thomaseizinger thomaseizinger marked this pull request as ready for review October 17, 2023 07:19
@thomaseizinger thomaseizinger added the trivial Marks PRs which are considered trivial and don't need approval from another maintainer. label Oct 17, 2023
@thomaseizinger
Copy link
Contributor Author

Merging to unblock CI of other PRs.

@mergify mergify bot merged commit f12e015 into master Oct 17, 2023
72 checks passed
@mergify mergify bot deleted the ci/label-ignore branch October 17, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant