refactor: inline quicksink crate
#4711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts. Could you please resolve them @kayabaNerve? 🙏 |
Resolves #4705 without an increase in semver burden. Decrease Cargo.lock by one package and enables any/all future maintenance.
|
Feel free to say this also shouldn't have a changelog entry. |
thomaseizinger
changed the title
quicksink crate
thomaseizinger
approved these changes
Oct 23, 2023
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
jxs
pushed a commit
to jxs/rust-libp2p
that referenced
this pull request
Jul 11, 2024
Adds the quicksink crate, which is offered under the MIT or Apache 2 license, as a module. This enables maintenance since quicksink itself has been archived for a year in a half. Resolves libp2p#4705. Pull-Request: libp2p#4711.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the quicksink crate, which is offered under the MIT or Apache 2 license, as a module. This enables maintenance since quicksink itself has been archived for a year in a half.
Resolves #4705.
Notes & open questions
Change checklist