Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upnp): ignore oneshot sender error when receiver is dropped #5096

Merged
merged 6 commits into from
Jan 21, 2024
Merged

fix(upnp): ignore oneshot sender error when receiver is dropped #5096

merged 6 commits into from
Jan 21, 2024

Conversation

dariusc93
Copy link
Member

Description

Resolves #5077.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

jxs
jxs approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks Darius!

@thomaseizinger thomaseizinger changed the title fix: Ignore oneshot sender error when receiver is dropped fix(upnp): ignore oneshot sender error when receiver is dropped Jan 17, 2024
thomaseizinger
thomaseizinger requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note regarding the changelog entry, otherwise LGTM!

protocols/upnp/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot merged commit db80bbf into libp2p:master Jan 21, 2024
72 of 73 checks passed
@thomaseizinger
Copy link
Contributor

This is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upnp: Panics when defaulting for Toggle
3 participants
@dariusc93 @thomaseizinger @jxs