Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(examples): change file-sharing from async-std to tokio #5191

Merged
merged 4 commits into from
Feb 29, 2024
Merged

refactor(examples): change file-sharing from async-std to tokio #5191

merged 4 commits into from
Feb 29, 2024

Conversation

bklaing2
Copy link
Contributor

Description

Closes: #5180
Related: #4449.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

dariusc93
dariusc93 reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments but overall LGTM

examples/file-sharing/src/network.rs Outdated Show resolved Hide resolved
examples/file-sharing/src/network.rs Outdated Show resolved Hide resolved
jxs
jxs previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jxs jxs added the send-it label Feb 28, 2024
@mergify mergify bot dismissed jxs’s stale review February 28, 2024 17:20

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@jxs jxs added send-it and removed send-it labels Feb 28, 2024
@jxs jxs added send-it and removed send-it labels Feb 29, 2024
@mergify mergify bot merged commit cc29860 into libp2p:master Feb 29, 2024
71 of 73 checks passed
@jxs
Copy link
Member

jxs commented Feb 29, 2024

Thanks! ❤️
Btw @bklaing2 would you be up for updating the original #4449 issue with the tracklist of examples and tutorials already with
tokio and the remaining ones still with async-std?

guillaumemichel pushed a commit that referenced this pull request Mar 28, 2024
@bklaing2 @guillaumemichel
refactor(examples): change file-sharing from async-std to tokio
bbfac65 
Closes: #5180
Related: #4449.

Pull-Request: #5191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor file-sharing example to use tokio instead of async-std
3 participants
@bklaing2 @jxs @dariusc93