Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: raise MSRV to 1.75 #5266

Merged
merged 3 commits into from
Mar 29, 2024
Merged

chore: raise MSRV to 1.75 #5266

merged 3 commits into from
Mar 29, 2024

Conversation

jxs
Copy link
Member

@jxs jxs commented Mar 25, 2024

Description

To allow merging #5232
CC @SuperFluffy since you commented on #4692

@dariusc93
Copy link
Member

I wonder if it would make more sense to bump the msrv 1.75 due to the stabilization of async fn in traits and returning impl trait. Thoughts on that?

Copy link
Member Author

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dariu, makes sense. Updated to 1.75 instead

@jxs jxs added the trivial Marks PRs which are considered trivial and don't need approval from another maintainer. label Mar 29, 2024
@jxs jxs changed the title chore: bump MSRV to 1.74 chore: bump MSRV to 1.75 Mar 29, 2024
@jxs jxs changed the title chore: bump MSRV to 1.75 chore: raise MSRV to 1.75 Mar 29, 2024
Copy link
Contributor

mergify bot commented Mar 29, 2024

This pull request has merge conflicts. Could you please resolve them @jxs? 🙏

@jxs jxs added the send-it label Mar 29, 2024
@mergify mergify bot merged commit 855ff8c into libp2p:master Mar 29, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants