Add unit tests for core::nodes::NodeStream #535
Conversation
core/src/nodes/node.rs
Outdated
|
|
||
| #[test] | ||
| #[ignore] | ||
| fn opening_substream_notifies_task() { |
There was a problem hiding this comment.
Not sure how to test this code from open_substream():
if let Some(task) = self.to_notify.take() {
task.notify();
}Pointers appreciated!
There was a problem hiding this comment.
The to_notify has been removed in the master branch.
core/src/nodes/node.rs
Outdated
| @@ -86,7 +86,16 @@ enum Addr<TAddrFut> { | |||
| /// A successfully opened substream. | |||
| pub type Substream<TMuxer> = muxing::SubstreamRef<Arc<TMuxer>>; | |||
|
|
|||
| impl<TMuxer> fmt::Debug for Substream<TMuxer> | |||
There was a problem hiding this comment.
This should be implemented on muxing::SubstreamRef, not on this type.
core/src/tests/dummy_muxer.rs
Outdated
| extern crate futures; | ||
|
|
||
| use std::io::Error as IoError; | ||
| use ::muxing::StreamMuxer; |
core/src/tests/dummy_muxer.rs
Outdated
| _ => unimplemented!() | ||
| } | ||
| } | ||
| #[allow(unused_variables)] |
There was a problem hiding this comment.
Don't use this allow. Replace the unused parameter names with underscores instead.
core/src/tests/dummy_muxer.rs
Outdated
| #[allow(unused_variables)] | ||
| fn destroy_outbound(&self, substream: Self::OutboundSubstream) {} | ||
| #[allow(unused_variables)] | ||
| fn read_substream(&self, substream: &mut Self::Substream, buf: &mut [u8]) -> Result<usize, IoError> { Ok(1) } |
There was a problem hiding this comment.
Use unreachable!() instead of returning a wrong value. Same for all the methods that shouldn't be called.
core/src/tests/dummy_muxer.rs
Outdated
|
|
||
| #[derive(Debug)] | ||
| pub struct DummyMuxer{ | ||
| pub in_connection: DummyConnection, |
There was a problem hiding this comment.
You should either have setters or public fields, but not both.
core/src/tests/dummy_muxer.rs
Outdated
|
|
||
| #[derive(Debug, PartialEq)] | ||
| pub enum DummyConnectionState { | ||
| Substream, |
There was a problem hiding this comment.
What do the Substream and Open variants mean? Once a substream is open, the substream is yielded as a DummySubstream and the state should reset to Pending.
|
@tomaka ptal |
core/src/nodes/node.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn prints_pretty_debug_info() { |
There was a problem hiding this comment.
This is the only contention point. I'm not totally sure we want to test the output of the Debug implementation.
There was a problem hiding this comment.
Cool, I'll just remove it from here and if/when #538 lands it'll be there (or not).
…e-listeners * upstream/master: Add unit tests for core::nodes::NodeStream (libp2p#535)
…pl-for-node-event * upstream/master: Add unit tests for core::nodes::NodeStream (libp2p#535) Implement GET_PROVIDERS/ADD_PROVIDER Kademlia messages (libp2p#530) Make secio almost compile for asmjs/wasm (libp2p#519) Make it possible to accept/deny nodes in CollectionsStream (libp2p#512) Fix polling in handled_node.rs (libp2p#531) Remove notifying tasks (libp2p#528) Fix handler not properly shut down, and write test for this (libp2p#514) Use unsigned-varints, add BLAKE2 support in multihash (libp2p#525) Upgrade smallvec version to fix license issue (libp2p#526)
No description provided.