fix(mdns): Handle problems on Apple platforms #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Apple platforms the tests regarding IPv6 and mDNS always fail. This is because the system service mdnsresponder uses that port. To check that it's running run:
mDNSResponder is integral to the Apple platform since it powers services like AirPlay; disabling it will impact user experience.
For more information on mDNSResponder (it's Open Source): https://github.com/apple-oss-distributions/mDNSResponder
The PR ignores the tests on affected platforms and displays a more helpful error message on the same platforms.
Notes & open questions
The actual correct fix would be to use the designated Apple C APIs to register the services there. The entrypoint is CFNetService.
Change checklist