Shut down yamux and fix mplex shutdown. #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplex gets a new flag `is_shutdown` to keep track of when `shutdown` has been called. We need to make certain that after the shutdown no more `Sink::poll_complete` or `Sink::start_send` calls are being made which may result in a panic.
tomaka
approved these changes
Oct 11, 2018
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Oct 11, 2018
…pl-for-node-event * upstream/master: Shut down yamux and fix mplex shutdown. (libp2p#559) Add `StreamMuxer::flush`. (libp2p#534) Tests for nodes/listeners.rs (libp2p#541) Deny relative addresses for UNIX domain sockets (libp2p#548) Optimise `Multiaddr::append`. (libp2p#549)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Oct 16, 2018
…e-handled_node * upstream/master: Remove the old API (libp2p#565) Change some `nat_traversal`s to consider a prefix. (libp2p#550) Add some documentation to listeners stream (libp2p#547) Add shutdown functionality to `NodeStream`. (libp2p#560) Shut down yamux and fix mplex shutdown. (libp2p#559)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Oct 17, 2018
…e-handled_node_tasks * dp/chore/test-core-handled_node: Fix broken test Clarify the behaviour of is_shutting_down Fixes broken test after upstream changes Remove the old API (libp2p#565) Change some `nat_traversal`s to consider a prefix. (libp2p#550) Add some documentation to listeners stream (libp2p#547) Add shutdown functionality to `NodeStream`. (libp2p#560) Shut down yamux and fix mplex shutdown. (libp2p#559)
AgeManning
pushed a commit
to jxs/rust-libp2p
that referenced
this pull request
Dec 6, 2023
* split ControlAction variants into its own structs which will help for the goal of prioritizing GRAFT and PRUNE messages over IWANT/IHAVE. * split control messages for different priorities * send GRAFT messages immediately when subscribing a topic, instead of doing it in the next heartbeat via control pool. * send PRUNE messages immediately when leaving a topic, instead of doing it in the next heartbeat via control pool. * send IWANT messages immediately when handling IHAVE tests are changed due to how count_control_messages work. Previously when counting messages they were consumed from the source: control_pool and the NetworkBehaviour events list, with the new channels, to read a message one has to consume it, that's why test numbers were changed. * send IHAVE messages immediately when emitting gossip * remove no longer used control_pool * clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mplex gets a new flag
is_shutdownto keep track of whenshutdownhas been called. We need to make certain that after the shutdown no moreSink::poll_completeorSink::start_sendcalls are being made which may result in a panic.