Skip to content

Fix panicking when Kad responder is destroyed #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Fix panicking when Kad responder is destroyed #575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d5f223
Fix panicking when Kad responder is destroyed
tomaka Oct 18, 2018
2800db3
Merge branch 'master' into fix-kad-panic
tomaka Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions protocols/kad/src/kad_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,10 +360,11 @@ where
},
Some(EventSource::LocalResponse(message)) => {
let future = message
.map_err(|_| {
.map_err(|err| {
// The user destroyed the responder without responding.
warn!("Kad responder object destroyed without responding");
panic!() // TODO: what to do here? we have to close the connection
// TODO: what to do here? we have to close the connection
IoError::new(IoErrorKind::Other, err)
})
.and_then(move |message| {
kad_sink
Expand Down