Remove the tokio-core dependency where not necessary #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
force-pushed
the
tokio-core-dep
branch
from
9c0c192 to
7abd400
Compare
eira-fransham
approved these changes
Dec 7, 2017
| @@ -29,11 +29,11 @@ | |||
|
|
|||
| macro_rules! peerstore_tests { | |||
| ({$create_peerstore:expr} $({$stmt:stmt})*) => { | |||
| extern crate multihash; | |||
There was a problem hiding this comment.
Probably you want to put the mod whatever in this macro too (instead of requiring the user to write it) so you don't get obnoxious and difficult-to-handle errors if you call this twice in the same module
There was a problem hiding this comment.
Discussed IRL and agreed that we wouldn't do that because it adds an indentation level and because the JSON backend requires an additional crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary step for #23