-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use full path for std result in derive macros #5839
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you also update swarm-derive version in Cargo.toml and also update the version in the workspace Cargo.toml? :)
…rust-libp2p into 5833-fix-derive-macro
Of course, thank you! |
Can you update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Looks like we can ignore the error from CI since it relies on the git tag to be created for the crate. CC @jxs |
Replace the
Result
in the./swarm-derive/src/lib.rs
file withstd::result::Result
.Fixes #5833