Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use full path for std result in derive macros #5839

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Slava2001
Copy link

Replace the Result in the ./swarm-derive/src/lib.rs file with std::result::Result.
Fixes #5833

Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also update swarm-derive version in Cargo.toml and also update the version in the workspace Cargo.toml? :)

@Slava2001
Copy link
Author

LGTM. Can you also update swarm-derive version in Cargo.toml and also update the version in the workspace Cargo.toml? :)

Of course, thank you!

@dariusc93
Copy link
Member

Can you update the Cargo.lock as well?

Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dariusc93
Copy link
Member

Looks like we can ignore the error from CI since it relies on the git tag to be created for the crate.

CC @jxs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in derive macro NetworkBehaviour
2 participants