Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When yamux connection is closing it should:
GoAway
frame.But test showed that pending frames from
stream_receivers
andGoAway
frame were not sent.Commits introducing this bug:
VecDeque
withOption
,which caused loss of pending frames,
because only last pending frame was stored in
Option
trying to fix loss of pending frames.
Option
back toVecDeque
,so all pending frames are stored again.
so pending frames are collected,
but not sent.
This PR provides test to reproduce it, and reverts 297e9eb and af8f693 to fix it.