[Working Draft] Fetch protocol spec #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Aug 15, 2019
5 tasks
vyzo
reviewed
Aug 16, 2019
|
|
||
| ``` | ||
| message FetchRequest { | ||
| string identifier = 1; |
There was a problem hiding this comment.
why not call this either key or id?
There was a problem hiding this comment.
it's more consistent with the document, but it's a nit really.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial stab at putting together a spec for the
Fetchprotocol. As explained in the spec this protocol is basically just a simple network request forFetch(key) (value, statusCode).The document contains both the answers to questions about a Working Draft and put together the spec outline (as detailed in the lifecycle document).
^ @vyzo @raulk @Stebalien