p2p-circuit v2 spec #325

vyzo · 2021-05-05T11:19:46Z

No description provided.

mxinden

🙏 Thanks @vyzo for creating the draft!

relay/circuit-v2.md

mxinden · 2021-05-05T15:49:20Z

relay/circuit-v2.md

+  optional int64 data = 2;     // bytes
+}
+
+enum Status {


I would prefer to split Status in HopStatus and StopStatus, making invalid states impossible at the type level.

See libp2p/go-libp2p-circuit#125

it's type pollution and these invalidities are very much trivial; I don't feel too strongly about it however.

Also, implementations must be prepared to handle unknown error status codes anyway, to support future extensions.

relay/circuit-v1.md

Co-authored-by: Max Inden <mail@max-inden.de>

vyzo · 2021-05-10T11:54:39Z

Fleshed out the remaining sections and turned the thorny integers into unsigned.

@mxinden this should be ready for review; note the changes in the vouchers, they are now signed envelopes (which means both our implementations will need to change).

mxinden

Fleshed out the remaining sections

Thank you for the detailed protocol description. Very much appreciated.

relay/circuit-v2.md

For the sake of consistency across the specifications use plantuml to picture circuit relay v2 protocol interaction.

Co-authored-by: Max Inden <mail@max-inden.de>

relay/circuit-v2: Replace excalidraw with plantuml

vyzo · 2021-05-11T08:03:19Z

summoning @Stebalien @raulk -- this is ready for your review.

relay/circuit-v2.md

Co-authored-by: raulk <raul@protocol.ai>

jacobheun · 2021-05-27T21:49:18Z

@mxinden any concerns with landing this? The spec is still working draft so edits can still be subsequently pushed as needed until we hit Candidate Recommendation.

mxinden

@mxinden any concerns with landing this? The spec is still working draft so edits can still be subsequently pushed as needed until we hit Candidate Recommendation.

Merging and addressing all future changes through separate pull requests sounds good to me.

In general I am in favor of many small pull requests over one large pull request, as a single large pull request is at risk of being stalled due to a couple small discussion points.

mxinden · 2021-06-07T14:22:36Z

@vyzo friendly ping. Can this be merged?

vyzo · 2021-06-07T18:17:13Z

needs a couple more edits, will get to it.

…

On Mon, Jun 7, 2021, 17:22 Max Inden ***@***.***> wrote: @vyzo <https://github.com/vyzo> friendly ping. Can this be merged? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#325 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAI4SVRCGKD7M6XWBH55E3TRTI35ANCNFSM44EPM74Q> .

Co-authored-by: raulk <raul@protocol.ai>

vyzo · 2021-06-08T12:21:40Z

@raulk this should be ready for merge.

mxinden · 2021-06-25T16:47:59Z

@vyzo @raulk friendly ping. Any objections to this being merged?

vyzo · 2021-06-25T16:49:14Z

no objections from me, waiting on @raulk to green tick.

vyzo added 2 commits May 5, 2021 13:18

move README to circuit-v1.md

119e237

circuit v2 spec preliminaries

22e2721

vyzo requested review from Stebalien, raulk and mxinden May 5, 2021 11:19

mxinden mentioned this pull request May 5, 2021

NAT traversal tracking issue #312

Open

mxinden reviewed May 5, 2021

View reviewed changes

mxinden linked an issue May 5, 2021 that may be closed by this pull request

Add spec fo circuit relay v2 protocol #314

Closed

vyzo and others added 7 commits May 5, 2021 21:04

copy edit

91f2ab6

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

6b791ab

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

e36fe48

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

f8ca5d2

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

16027bc

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

bbb2337

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

bfa6918

Co-authored-by: Max Inden <mail@max-inden.de>

jacobheun mentioned this pull request May 6, 2021

Project Flare(decentralised Hole Punching) Phase1 Meta Issue libp2p/go-libp2p#1039

Closed

23 tasks

flesh out spec

3c0e757

vyzo changed the title ~~[WIP] p2p-circuit v2 spec~~ p2p-circuit v2 spec May 10, 2021

mxinden reviewed May 10, 2021

View reviewed changes

mxinden and others added 7 commits May 10, 2021 16:12

relay/circuit-v2: Replace excalidraw with plantuml

5efd8e8

For the sake of consistency across the specifications use plantuml to picture circuit relay v2 protocol interaction.

copy edit

e2cbf5f

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

e242414

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

186bf1c

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

803682e

Co-authored-by: Max Inden <mail@max-inden.de>

copy edit

8bea5d0

Co-authored-by: Max Inden <mail@max-inden.de>

Merge pull request #326 from mxinden/rfc/circuit-v2

cf3e6d2

relay/circuit-v2: Replace excalidraw with plantuml

mxinden reviewed May 11, 2021

View reviewed changes

relay/circuit-v2.md Outdated Show resolved Hide resolved

mxinden reviewed May 11, 2021

View reviewed changes

relay/circuit-v2.md Outdated Show resolved Hide resolved

vyzo and others added 11 commits May 18, 2021 17:12

copy edit

15788ce

Co-authored-by: raulk <raul@protocol.ai>

copy edit

ad64f2f

Co-authored-by: raulk <raul@protocol.ai>

copy edit

0bebcc1

Co-authored-by: raulk <raul@protocol.ai>

copy edit

fb477c7

Co-authored-by: raulk <raul@protocol.ai>

copy edit

9cb054f

Co-authored-by: raulk <raul@protocol.ai>

copy edit

f5c1d62

Co-authored-by: raulk <raul@protocol.ai>

copy edit

962a80d

Co-authored-by: raulk <raul@protocol.ai>

copy edit

b1ac56d

Co-authored-by: raulk <raul@protocol.ai>

copy edit

d00f2c7

Co-authored-by: raulk <raul@protocol.ai>

copy edit

1b63664

Co-authored-by: raulk <raul@protocol.ai>

copy edit

4d52042

Co-authored-by: raulk <raul@protocol.ai>

This was referenced May 25, 2021

NAT traversal libp2p/rust-libp2p#2052

Open

The relay protocol could be split in two #105

Closed

mxinden approved these changes May 28, 2021

View reviewed changes

raulk mentioned this pull request Jun 2, 2021

p2p-circuit v2 libp2p/go-libp2p-circuit#125

Merged

6 tasks

add wording about relay over relay

62c641b

mxinden approved these changes Jun 2, 2021

View reviewed changes

vyzo and others added 3 commits June 8, 2021 15:13

copy edit

e943af6

Co-authored-by: raulk <raul@protocol.ai>

editorial changes

c3b40e4

add multicoded and envelope domain for vouchers

c541d2c

vyzo mentioned this pull request Jun 8, 2021

add libp2p-relay-rsvp codec multiformats/multicodec#216

Merged

raulk approved these changes Jun 29, 2021

View reviewed changes

mxinden merged commit 3d73852 into master Jun 29, 2021

mxinden mentioned this pull request Jul 1, 2021

*: Update Kademlia and Circuit Relay v2 links #345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

p2p-circuit v2 spec #325

p2p-circuit v2 spec #325

vyzo commented May 5, 2021

mxinden left a comment

mxinden May 5, 2021

vyzo May 5, 2021

vyzo May 11, 2021

vyzo commented May 10, 2021

mxinden left a comment

vyzo commented May 11, 2021

jacobheun commented May 27, 2021

mxinden left a comment

mxinden commented Jun 7, 2021

vyzo commented Jun 7, 2021 via email

vyzo commented Jun 8, 2021

mxinden commented Jun 25, 2021

vyzo commented Jun 25, 2021

p2p-circuit v2 spec #325

p2p-circuit v2 spec #325

Conversation

vyzo commented May 5, 2021

mxinden left a comment

Choose a reason for hiding this comment

mxinden May 5, 2021

Choose a reason for hiding this comment

vyzo May 5, 2021

Choose a reason for hiding this comment

vyzo May 11, 2021

Choose a reason for hiding this comment

vyzo commented May 10, 2021

mxinden left a comment

Choose a reason for hiding this comment

vyzo commented May 11, 2021

jacobheun commented May 27, 2021

mxinden left a comment

Choose a reason for hiding this comment

mxinden commented Jun 7, 2021

vyzo commented Jun 7, 2021 via email

vyzo commented Jun 8, 2021

mxinden commented Jun 25, 2021

vyzo commented Jun 25, 2021