webrtc(browser-browser): specify init channel for connection establishment #578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection establishment doesn't work if we don't create a channel before creating the SDP offer.
Not exactly very helpful but some info on this SO question: https://stackoverflow.com/questions/38867763/why-i-have-to-open-data-channel-before-send-peer-connection-offer/38872920#38872920
js-libp2p already does this: https://github.com/libp2p/js-libp2p/blob/master/packages/transport-webrtc/src/private-to-private/handler.ts#L116-L119
go-libp2p: https://github.com/libp2p/go-libp2p/blob/webrtcprivate/transport/p2p/transport/webrtcprivate/transport.go#L242
I think this should be a part of the spec.