Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementations and definitions of floodsub and gossipsub #68

Closed
wants to merge 2 commits into from

Conversation

jamesray1
Copy link
Contributor

No description provided.

@bigs
Copy link
Contributor

bigs commented Jun 6, 2018

I think these blurbs are likely to go stale quite quickly, but I do think it's important that we get some specs for Floodsub and Gossipsub in this repo and reference them from this doc. Individual docs could elaborate on specifics of each protocol and point to implementations.

@jamesray1
Copy link
Contributor Author

Agreed, but it's better to update now (and update again when necessary, or at least it will be outdated but still provide more information than otherwise).

@jamesray1
Copy link
Contributor Author

I still think the technical details on floodsub and pubsub will not go out of date, even if they are replaced by another later on.

@ghost
Copy link

ghost commented Jun 27, 2018

Is gossipsub what's called epidemic-pubsub in libp2p/research-pubsub#17? Anyway, there's another impl of gossipsub in gerbil: https://github.com/vyzo/gerbil-simsub

@jamesray1
Copy link
Contributor Author

jamesray1 commented Jun 28, 2018

Thanks, I added a link for the gerbil impl. See also https://github.com/libp2p/go-floodsub/issues/77#issuecomment-387404293 (although I presume you've already read that) and https://en.wikipedia.org/wiki/Gossip_protocol.

A gossip protocol[1] is a procedure or process of computer-computer communication that is based on the way social networks disseminate information or how epidemics spread.

So based on that, but not having read libp2p/research-pubsub#17 yet, I would say that gossipsub can also be referred to as epidemic-pubsub.

@ghost
Copy link

ghost commented Jun 28, 2018

So based on that

I wasn't asking based on definitions ;) We have two implementations which we call gossipsub, and we have a spec that we call epidemic-pubsub, and I was wondering whether they're the same -- they are.

@ghost
Copy link

ghost commented Jun 28, 2018

I was wondering whether they're the same -- they are.

I'm gonna merge that spec by tomorrow, and sprinkle in a couple of mentions of "gossipsub".

@ghost
Copy link

ghost commented Jul 4, 2018

@jamesray1 hey the gossipsub spec is now merged, and I updated links wherever it seemed appropriate. Does that look good to you now?

@ghost ghost closed this Jul 11, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants