-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error logging for JS/TS ping test #119
improve error logging for JS/TS ping test #119
Conversation
helps debugging issues in case things go haywire while testing the JS implementation
Thanks. What errors did you run into that this logged? If you have time, could you rebase to #121. If not, no worries. I can take :) |
Rebased it. Two issues:
|
console.error(`unexpected exception in ping test: ${err}\n Errors: ${err.errors}`) | ||
} else { | ||
console.error(`unexpected exception in ping test: ${err}`) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am no JS expert but I think if you pass the err
as an argument to console.error
, it will display a nice stacktrace.
console.error(`unexpected exception in ping test: ${err}\n Errors: ${err.errors}`) | |
} else { | |
console.error(`unexpected exception in ping test: ${err}`) | |
} | |
console.error(`unexpected exception in ping test: ${err}\n Errors: ${err.errors}`) | |
} else { | |
console.error(`unexpected exception in ping test`, err) | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be. Feel free to take over this PR by the way @MarcoPolo. You probably know better what you want to do with this suggestion and PR. My intention was more to share the need for better error logging in case the happy path is not being followed.
2516f30
to
98161af
Compare
@GlenDC this PR has merge conflicts |
I'm taking this pr. |
Added logs to #121 |
helps debugging issues in case
things go haywire while testing the JS implementation