ping/_composition: use latest release in interop-latest #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsenta
force-pushed
the
feat/interop-latest-tests-against-releases
branch
2 times, most recently
from
be1774e to
7f0d044
Compare
laurentsenta
force-pushed
the
feat/interop-latest-tests-against-releases
branch
from
7f0d044 to
fc7a0e0
Compare
|
See related discussion in libp2p/rust-libp2p#2835 I still think we could test But I want to merge interop as soon as possible in rust and make sure we don't break go-libp2p, so let's have a follow-up discussion when interop test is running everywhere! |
laurentsenta
commented
Sep 6, 2022
| @@ -14,38 +14,26 @@ | |||
| go_proxy_url = "https://proxy.golang.org" | |||
|
|
|||
| {{ with (load_resource "./go.toml") }} | |||
| {{ with .master }} | |||
| {{ with (index .groups 0) }} | |||
There was a problem hiding this comment.
@marten-seemann No worries, I requested your review regarding the feature itself,
nothing much to see in the code, quick overview:
- we use go templates to simplify maintenance,
- with
load_resourcewe load https://github.com/libp2p/test-plans/blob/master/ping/_compositions/go.toml in the template.
This PR replaces the use of the master version with the latest release registered in .groups (loaded from the go.toml file)
mxinden
approved these changes
Sep 6, 2022
4 tasks
This was referenced Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the interop (latest) tests so that we build & test:
(before we would test against
masterbranch for each of these projects).