Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to syn 2 #317

Closed
XAMPPRocky opened this issue Sep 9, 2024 · 2 comments
Closed

Update to syn 2 #317

XAMPPRocky opened this issue Sep 9, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@XAMPPRocky
Copy link
Collaborator

No description provided.

@XAMPPRocky XAMPPRocky added kind/enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 9, 2024
@shahn
Copy link
Contributor

shahn commented Sep 14, 2024

I was wanting to take a stab at this, but when I did I stumbled across option_type, which seems to be undocumented and entirely untested. It seems to give the option to specify some_variant and none_variant for an optional type, but both are entirely unused in the code base. Is this an unfinished idea, left in the code? Should it be implemented somehow and tested, or is it OK to remove?

@XAMPPRocky
Copy link
Collaborator Author

@shahn It is a leftover from an older version, I would recommend making a first PR removing it, and then following up with the syn 2 update :)

@shahn shahn mentioned this issue Sep 15, 2024
Merged
shahn added a commit to shahn/rasn that referenced this issue Oct 18, 2024
@shahn
Update to syn2
67314ef 
This implements librasn#317
@shahn shahn mentioned this issue Oct 18, 2024
Merged
XAMPPRocky pushed a commit that referenced this issue Oct 18, 2024
@shahn
Update to syn2 (#345)
156177e 
* Update to syn2

This implements #317

* Fix clippy after the Rust 1.82 update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shahn @XAMPPRocky