Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rasn needlessly pulls in rayon as a dependency #359

Closed
decryphe opened this issue Oct 28, 2024 · 1 comment · Fixed by #362 or #363
Closed

rasn needlessly pulls in rayon as a dependency #359

decryphe opened this issue Oct 28, 2024 · 1 comment · Fixed by #362 or #363

Comments

@decryphe
Copy link
Contributor

When I add a crate, I normally try to minimize the number of new dependencies that get pulled in.

When doing so, I noticed that rasn-derive depends on rayon. Investigating further shows that it only uses rayon once, to do a more convenient flat_map-operation. See: https://github.com/librasn/rasn/blob/main/macros/src/config.rs#L1259

Is this really necessary? Would a PR that removes this dependency be welcomed? I can do this maintenance task for you and change the offending passage to only depend on std.

Also, does rasn 0.18.0 actually not compile when configuring "default-features = false"? I'll need the derives, so it doesn't really affect me, but I noticed this because I normally start with no default features and then add what I need as I go.

@Nicceboy
Copy link
Contributor

It seems like that this particular use case of rayon might not be that useful, so maybe it can be removed.

Also, does rasn 0.18.0 actually not compile when configuring "default-features = false"? I'll need the derives, so it doesn't really affect me, but I noticed this because I normally start with no default features and then add what I need as I go.

This is likely impossible use case and rasn will not compile currently since at least open type depends on those macros and the dependency is declared on other few places as well, so it should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants