Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup some unnecessary dependencies #362

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

Nicceboy
Copy link
Contributor

Fixes #359

Seems like rayon is only used for processing constraints in parallel and typically the amount of constraints is rather small.
I could not measure any drastic performance difference when compiling whole workspace, so I just removed rayon:

# With rayon
cargo build --workspace --all-targets  142.49s user 17.37s system 742% cpu 21.517 total

# Without rayon
cargo build --workspace --all-targets  141.91s user 17.11s system 752% cpu 21.136 total

Also arrayvec has been removed as I could not find any usage for it.

There is constant equivalent for current konst dependency usage, so this removes that as well.

@Nicceboy
Copy link
Contributor Author

I also removed the macros feature since it is not currently possible to compile rasn without it. Or should we rework Open type before doing so?

@XAMPPRocky
Copy link
Collaborator

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 59cb8ea into librasn:main Oct 30, 2024
65 checks passed
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
@Nicceboy Nicceboy deleted the dep-cleanup branch October 30, 2024 10:00
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rasn needlessly pulls in rayon as a dependency
2 participants