Extract proc macro impl into own crate #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahn
changed the title
|
I guess another idea would be to do it like serde does it, using a non-published crate that has a symbolic link for the actual implementation, to use the non-published crate for tests etc and publish the rest like normal. I guess that would be preferable, here, too. I will follow up with a commit to add that |
|
Hrm, that has the downside of Windows (and serde actually publishes the serde_derive_internals crate, too). Do you have any preference? |
This helps testability of the proc macro, allows fuzzing it to find panics, and would also allow benchmarking.
shahn
force-pushed
the
split_proc_macro
branch
from
0d034e8 to
66804f4
Compare
|
Thank you for your PR! We can just go with a separate crate for now. |
This was referenced Nov 1, 2024
Closed
Merged
This was referenced Nov 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps testability of the proc macro, allows fuzzing it to find panics, and would also allow benchmarking.
This might also help investigations like in #362 and #363 to see if there are actual performance changes to the derive macros.
Careful review is probably necessary, because a new crate is introduced. I am happy to take this into any direction, but it is also the foundation for the error message improvements for the derive macros I am working on.