Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165
I cross-checked the encoding output in the issue using asn1.io, assuming the following ASN1 to represent the struct mentioned here:
When encoding nested
SEQUENCE
s, therasn
encoder did not take the custom tag into account, which in case of the nesteskey
-SEQUENCE
and was producing a wrong tag, i.e.UNIVERSAL 0
. I changed the call in the macro for encoding inner items from a simpleencode
toencode_with_tag
. The tests run fine, and I tried to trace the different cases we could encounter through the macro process and I couldn't find any side-effects on other cases. You'll likely have a much more complete view of how the different macro calls come together, @XAMPPRocky.Let me know if I need to do more digging.