Add basic optimizations for allocations in OER #323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lack of pre-allocations and not using existing buffers created many unnecessary allocations.
This will reduces them a bit.
I trialed several data types for output buffer, and
seems to be best. I tried sharing direct reference of
Vec<u8>
and alsoBytes/BytesMut
.Direct reference was too difficult to add since encoder uses itself recursively.
BytesMut
was much slower. Maybe this is okay for a while.Now the buffer is re-used when possible. e.g. no length calculation requirement afterwards.
Current improvement based on the integer test: